Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add is_nan() and is_not_nan()#65

Merged
saturnboy merged 1 commit intoassertpy:masterassertpy/assertpy:masterfrom
aarbouin:manage-math-nanCopy head branch name to clipboard
Sep 25, 2017
Merged

add is_nan() and is_not_nan()#65
saturnboy merged 1 commit intoassertpy:masterassertpy/assertpy:masterfrom
aarbouin:manage-math-nanCopy head branch name to clipboard

Conversation

@antoinearbouin
Copy link

In python math.nan != math.nan so it is not possible to use is_equal_to().
I add is_nan() and is_not_nan() methods to handle it.
Hope I do it correctly.

@coveralls
Copy link

coveralls commented Sep 18, 2017

Coverage Status

Coverage decreased (-0.7%) to 98.757% when pulling 75347d0 on Veknelyon:manage-math-nan into 3c421ca on ActivisionGameScience:master.

@antoinearbouin
Copy link
Author

Sorry, I didn't check versions. math.nan appears in python 3.5.

@saturnboy saturnboy self-assigned this Sep 24, 2017
@saturnboy
Copy link
Contributor

saturnboy commented Sep 24, 2017

@Veknelyon version compatibility is a huge pain now. Think it would get confusing to have >= 3.5 features. Let me think about this.

Looks like math.isnan() is >= 2.6...want to try that func directly?

@saturnboy saturnboy added this to the v1.0 milestone Sep 24, 2017
@saturnboy saturnboy merged commit 75347d0 into assertpy:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.