Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

code structure? #95

Copy link
Copy link
@amitwer

Description

@amitwer
Issue body actions

Hi,
When looking over the code I noticed that there is one huge file with all the assertions, and its quite difficult to find my way in it.
So, before I try to sort things and open a PR, is there a reason not to break it down to multiple classes? Since the user is only creating AssertionBuilder through the factory methods, it seems possible to either have Assertion inherit methods from a bunch of helper classes (FileAssertions, CollectionsAssertions, NumberASsertions etc.) or to initialize it with members that contain the implementation, so that the actual class will only have thin wrapper functions.

example:

def is_subset_of(val):
    self._collection_assertions.is_subset_of(val)
    return self
Reactions are currently unavailable

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.