[DRAFT] Support tokio::process::command.#223
Draft
nickpdemarco wants to merge 1 commit intoassert-rs:masterassert-rs/assert_cmd:masterfrom
nickpdemarco:nickpdemarco/tokio-commandnickpdemarco/assert_cmd:nickpdemarco/tokio-commandCopy head branch name to clipboard
Draft
[DRAFT] Support tokio::process::command.#223nickpdemarco wants to merge 1 commit intoassert-rs:masterassert-rs/assert_cmd:masterfrom nickpdemarco:nickpdemarco/tokio-commandnickpdemarco/assert_cmd:nickpdemarco/tokio-commandCopy head branch name to clipboard
tokio::process::command.#223nickpdemarco wants to merge 1 commit intoassert-rs:masterassert-rs/assert_cmd:masterfrom
nickpdemarco:nickpdemarco/tokio-commandnickpdemarco/assert_cmd:nickpdemarco/tokio-commandCopy head branch name to clipboard
Conversation
Contributor
|
According to our contributor guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After hitting this issue I tried to add basic support for
tokio::process::command. It requires a new trait,AsyncOutputAssertExtin order to get the following to compile:I have not yet done the due diligence to confirm this covers all reasonable use cases. Raising this PR for visibility and to ask for some guidance on how to get this production-ready. Documentation TODO.