Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Added babel-loader caching to improve subsequent build times.#777

Merged
SteveSandersonMS merged 1 commit intoaspnet:devaspnet/JavaScriptServices:devfrom
DanHarman:cache-babel-loaderDanHarman/JavaScriptServices:cache-babel-loaderCopy head branch name to clipboard
Mar 22, 2017
Merged

Added babel-loader caching to improve subsequent build times.#777
SteveSandersonMS merged 1 commit intoaspnet:devaspnet/JavaScriptServices:devfrom
DanHarman:cache-babel-loaderDanHarman/JavaScriptServices:cache-babel-loaderCopy head branch name to clipboard

Conversation

@DanHarman
Copy link
Contributor

@DanHarman DanHarman commented Mar 21, 2017

Added babel-loader caching which significantly improves build times. This is also used in the create-react-app template.

First run:

$ webpack
(node:2164) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Hash: f657172a5ca6dcdcb4ddfb908cb42dfef18c1ea5
Version: webpack 2.2.1
Child
    Hash: f657172a5ca6dcdcb4dd
    Time: 11244ms
                 Asset      Size  Chunks             Chunk Names
        main-client.js   49.7 kB       0  [emitted]  main-client
              site.css   1.56 kB       0  [emitted]  main-client
    main-client.js.map   31.6 kB       0  [emitted]  main-client
          site.css.map  85 bytes       0  [emitted]  main-client
Child
    Hash: fb908cb42dfef18c1ea5
    Time: 11228ms
             Asset     Size  Chunks             Chunk Names
    main-server.js  94.2 kB       0  [emitted]  main-server

Subsequent run:

$ webpack
(node:4936) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Hash: f657172a5ca6dcdcb4ddfb908cb42dfef18c1ea5
Version: webpack 2.2.1
Child
    Hash: f657172a5ca6dcdcb4dd
    Time: 3588ms
                 Asset      Size  Chunks             Chunk Names
        main-client.js   49.7 kB       0  [emitted]  main-client
              site.css   1.56 kB       0  [emitted]  main-client
    main-client.js.map   31.6 kB       0  [emitted]  main-client
          site.css.map  85 bytes       0  [emitted]  main-client
Child
    Hash: fb908cb42dfef18c1ea5
    Time: 3572ms
             Asset     Size  Chunks             Chunk Names
    main-server.js  94.2 kB       0  [emitted]  main-server

@dnfclas
Copy link

dnfclas commented Mar 21, 2017

@DanHarman,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@SteveSandersonMS SteveSandersonMS merged commit 365b2c5 into aspnet:dev Mar 22, 2017
@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Mar 22, 2017

Thanks very much for this!

@DanHarman
Copy link
Contributor Author

DanHarman commented Mar 22, 2017

@SteveSandersonMS Thanks to you and everyone else who has worked on this template - its a really great basis for an app, and I've learnt a lot about putting together a proper redux app from it. I actually learnt asp.net from one of your books too, so I owe you some thanks there too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanHarman @dnfclas @SteveSandersonMS
Morty Proxy This is a proxified and sanitized view of the page, visit original site.