Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

if not Win check added #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

if not Win check added #3653

wants to merge 1 commit into from

Conversation

ved1beta
Copy link

Skip nvrtc-builtins dependency on Windows

This PR modifies the CMake configuration to handle the nvrtc-builtins library
differently on Windows platforms where the library naming convention differs.

Description

This is a bug fix that addresses the issue with CUDA nvrtc-builtins library
not being found on Windows systems. The root cause is that Windows CUDA toolkit
prepends version information to the library name, making the standard library
search fail.

The changes:

  • Add platform-specific condition to skip nvrtc-builtins on Windows
  • Maintain existing behavior on other platforms
  • Fix build issues on Windows without affecting other platforms

Impact:

  • Windows builds will now complete successfully
  • No impact on other platforms or backends
  • No changes to existing functionality or API

This PR can be backported to older versions as it's a build system fix that
doesn't affect the core functionality.

Fixes: #3652

Changes to Users

No changes required for users. This is a build system fix that doesn't affect
the API or functionality. Existing code will continue to work as before.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@christophe-murphy
Copy link
Contributor

Thanks for this. We are currently overhauling the Windows installer build process so will be making some more changes and fixes soon including for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] CUDA nvrtc-builtins not found in windows
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.