Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update OpenCL to 3.0. Add checks around tests that use doubles. #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 21, 2023
Merged

Update OpenCL to 3.0. Add checks around tests that use doubles. #3338

merged 17 commits into from
Jan 21, 2023

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Nov 30, 2022

This updates the OpenCL standard to 3.0 from 1.2. Additionally this PR adds some checks around tests that use double precision numbers on devices that don't support double precision. This PR also fixes the pow function when fast math is used.

Description

  • Update OpenCL standard to 3.0
  • Add type checks around some tests that use doubles
  • Fix errors associated with pow with fast math in cuda
  • Update FindOpenCL.cmake in CMakeModules
  • Fix an error that caused CMake failures when OpenCL::cl2pp is found

Changes to Users

N/A

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@umar456 umar456 force-pushed the double_checks_opencl branch 7 times, most recently from 7234cb2 to 397459e Compare December 2, 2022 23:53
syurkevi
syurkevi reviewed Dec 6, 2022
View reviewed changes
src/backend/cuda/compile_module.cpp Outdated Show resolved Hide resolved
syurkevi
syurkevi reviewed Dec 6, 2022
View reviewed changes
CMakeModules/vcpkg/ports/opencl/vcpkg-cmake-wrapper.cmake Outdated Show resolved Hide resolved
syurkevi
syurkevi reviewed Dec 6, 2022
View reviewed changes
src/backend/opencl/platform.hpp Outdated Show resolved Hide resolved
@umar456 umar456 force-pushed the double_checks_opencl branch 2 times, most recently from 91824df to 659bc8b Compare January 11, 2023 21:16
@umar456 umar456 force-pushed the double_checks_opencl branch 6 times, most recently from 72d1247 to 0cda5a4 Compare January 20, 2023 19:40
@umar456 umar456 force-pushed the double_checks_opencl branch 2 times, most recently from ae41af0 to 0f54a02 Compare January 20, 2023 22:15
@umar456 umar456 force-pushed the double_checks_opencl branch from 0f54a02 to 1d36f1f Compare January 21, 2023 00:33
@umar456 umar456 merged commit 225a828 into arrayfire:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syurkevi syurkevi syurkevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umar456 @syurkevi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.