Fix issue where ndims was incorrectly used to calculate shape of input #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8bb9f1 to
86dcabb
Compare
syurkevi
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the assertion to validate the input shape of the stride, padding and dilation array
Description
In C functions, the way the shapes of the input shapes are passed into functions is
using an array of dim_t values and an unsigned integer. The unsigned integer is used
to indicate how many values are in the input array. It does not indicate the number of
axis of the resulting dim4 object. This distinction caused an error with the new
convolve functions.
Changes to Users
Users will be able to pass any values to the stride_dims, padding_dims and dilation_dims
values.
Checklist
[ ] Functions added to unified API[ ] Functions documented