This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Fix Fail to Build Examples if ARDUINO_SDK_PATH is not in Default Paths #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the variable ARDUINO_SDK_PATH is given by the command line `cmake ... -DARDUINO_SDK_PATH=<path-of-arduino-sdk>` rather than `export ARDUINO_SDK_PATH=<path-of-arduino-sdk>`, the examples are failed to build and output error in ArduinoSDKSeeker.cmake with unknown reason, though it's cached.
MrPointer
suggested changes
Jun 2, 2019
| @@ -67,6 +67,7 @@ else () | ||
| # Set default path if none is set | ||
| find_arduino_sdk(arduino_sdk_path) | ||
| set(ARDUINO_SDK_PATH "${arduino_sdk_path}" CACHE PATH "Arduino SDK Path") | ||
| set(ENV{ARDUINO_SDK_PATH} "${ARDUINO_SDK_PATH}") |
There was a problem hiding this comment.
Hmm I would wrap it in a conditional that applies only in the case where the env var isn't defined, as it's user's responsibility to set it.
There was a problem hiding this comment.
Agree. This behavior is really weird even the variable has been cached in the file CMakeCache.txt. I've checked this set won't affect the environment variables. I'll track on this to make a better solution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the variable ARDUINO_SDK_PATH is given by the command line
rather than
the examples are failed to build and output error in "ArduinoSDKSeeker.cmake" with unknown reason, though it's cached.