Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Better error handling when sketch was not compiled #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions 25 src/extension.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { posix } from 'path';
import { spawnSync } from 'child_process';
import deepEqual from 'deep-equal';
import WebRequest from 'web-request';
import { spawnSync } from 'child_process';
import vscode, { ExtensionContext } from 'vscode';
import { LanguageClient, CloseAction, ErrorAction, InitializeError, Message, RevealOutputChannelOn } from 'vscode-languageclient';

Expand Down Expand Up @@ -59,15 +60,33 @@ export function activate(context: ExtensionContext) {

async function startDebug(_: ExtensionContext, config: DebugConfig): Promise<boolean> {
let info: DebugInfo | undefined = undefined;
let rawStdout: string | undefined = undefined;
let rawStdErr: string | undefined = undefined;
try {
const args = ['debug', '-I', '-b', config.board.fqbn, config.sketchPath, '--format', 'json'];
const rawInfo = spawnSync(config.cliPath, args, { encoding: 'utf8' }).stdout.trim();
info = JSON.parse(rawInfo);
const { stdout, stderr } = spawnSync(config.cliPath, args, { encoding: 'utf8' });
rawStdout = stdout.trim();
rawStdErr = stderr.trim();
} catch (err) {
const message = err instanceof Error ? err.stack || err.message : 'Unknown error';
vscode.window.showErrorMessage(message);
return false;
}
if (!rawStdout) {
if (rawStdErr) {
if (rawStdErr.indexOf('compiled sketch not found in') !== -1) {
vscode.window.showErrorMessage(`Sketch '${posix.basename(config.sketchPath)}' was not compiled. Please compile the sketch and start debugging again.`);
} else {
vscode.window.showErrorMessage(rawStdErr);
}
}
return false;
}
try {
info = JSON.parse(rawStdout);
} catch (err) {
vscode.window.showErrorMessage(err);
}
if (!info) {
return false;
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.