Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Order custom board option menus as defined in platform configuration #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Now it's working
Signed-off-by: Günter Neiß <gneiss@web.de>
  • Loading branch information
gneiss15 committed Apr 24, 2025
commit 27a46a4eac9e537a751871f7da3f0e7080070730
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { inject, injectable } from '@theia/core/shared/inversify';
import PQueue from 'p-queue';
import {
BoardIdentifier,
// Produces Error: src/browser/contributions/boards-data-menu-updater.ts(10,3): error TS6133: 'ConfigOption' is declared but its value is never read.
// ConfigOption,
isBoardIdentifierChangeEvent,
Programmer,
} from '../../common/protocol';
Expand Down Expand Up @@ -72,8 +70,11 @@ export class BoardsDataMenuUpdater extends Contribution {
...ArduinoMenus.TOOLS__BOARD_SETTINGS_GROUP,
'z01_boardsConfig',
]; // `z_` is for ordering.
for (const { label, option, values } of configOptions ) {
const menuPath = [...boardsConfigMenuPath, `${option}`];
let i:number = 0;
for (const { label, option, values } of configOptions) {
// We want Menu Entries in order of configOptions
const order = String(i++).padStart(4)
const menuPath = [...boardsConfigMenuPath, `${order}`];
const commands = new Map<
string,
Disposable & { label: string }
Expand Down
6 changes: 0 additions & 6 deletions 6 arduino-ide-extension/src/common/protocol/boards-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,6 @@ export namespace ConfigOption {
Object.setPrototypeOf(this, ConfigOptionError.prototype);
}
}

export const LABEL_COMPARATOR = (left: ConfigOption, right: ConfigOption) =>
naturalCompare(
left.label.toLocaleLowerCase(),
right.label.toLocaleLowerCase()
);
}

export interface ConfigValue {
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.