fix: let the upload run when no board is selected

IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive the `no FQBN` error from the CLI and cannot cannot suggest selecting a board via the `Tools` > `Board` menu. Closes #1714 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
arduino · kittaakos · Feb 23, 2024 · Feb 23, 2024 · 3c5c014d45b457b1180c0bde8d78b35cb454c153
commit 3c5c014d45b457b1180c0bde8d78b35cb454c153
diff --git a/arduino-ide-extension/src/browser/contributions/user-fields.ts b/arduino-ide-extension/src/browser/contributions/user-fields.ts
@@ -74,7 +74,9 @@ export class UserFields extends Contribution {
  async checkUserFieldsDialog(forceOpen = false): Promise<boolean> {
    const key = this.selectedFqbnAddress();
    if (!key) {
-      return false;
+      // Let the upload continue without an FQBN and the CLI fail instead of disabling the upload from IDE.
+      // https://github.com/arduino/arduino-ide/issues/1714
+      return true;
    }
    /*
      If the board requires to be configured with user fields, we want