Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9a2d13f

Browse filesBrowse files
author
Akos Kitta
committed
Fixed dirty indicator of uncloseable widgets.
Closes #1034. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent b7dbe59 commit 9a2d13f
Copy full SHA for 9a2d13f

File tree

Expand file treeCollapse file tree

2 files changed

+7
-3
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+7
-3
lines changed

‎arduino-ide-extension/src/browser/style/editor.css

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/browser/style/editor.css
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
/* Show the dirty indicator on unclosable widgets. On hover, it should still show the dot instead of the X. */
22
/* https://github.com/arduino/arduino-pro-ide/issues/380 */
3-
.p-TabBar.theia-app-centers .p-TabBar-tab.p-mod-closable.theia-mod-dirty > .p-TabBar-tabCloseIcon:hover {
4-
background-size: 13px;
5-
background-image: var(--theia-icon-circle);
3+
.p-TabBar.theia-app-centers .p-TabBar-tab.p-mod-closable.a-mod-uncloseable.theia-mod-dirty > .p-TabBar-tabCloseIcon:before {
4+
content: "\ea71";
65
}
76

87
.monaco-list-row.show-file-icons.focused {

‎arduino-ide-extension/src/browser/theia/core/widget-manager.ts

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/browser/theia/core/widget-manager.ts
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ export class WidgetManager extends TheiaWidgetManager {
6666
if (title.closable) {
6767
title.closable = false;
6868
}
69+
// Show the dirty indicator on uncloseable widgets when hovering over the title. Instead of showing the `X` for close.
70+
const uncloseableClass = 'a-mod-uncloseable';
71+
if (!title.className.includes(uncloseableClass)) {
72+
title.className += title.className + ` ${uncloseableClass}`;
73+
}
6974
}
7075

7176
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.