Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 530cddb

Browse filesBrowse files
author
Akos Kitta
committed
fix: remove obsolete workaround code
1 parent 4a393ba commit 530cddb
Copy full SHA for 530cddb

File tree

3 files changed

+0
-44
lines changed
Filter options

3 files changed

+0
-44
lines changed

‎arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ import {
210210
MonacoEditorFactory,
211211
MonacoEditorProvider as TheiaMonacoEditorProvider,
212212
} from '@theia/monaco/lib/browser/monaco-editor-provider';
213-
import { StorageWrapper } from './storage-wrapper';
214213
import { NotificationManager } from './theia/messages/notifications-manager';
215214
import { NotificationManager as TheiaNotificationManager } from '@theia/messages/lib/browser/notifications-manager';
216215
import { NotificationsRenderer as TheiaNotificationsRenderer } from '@theia/messages/lib/browser/notifications-renderer';
@@ -879,9 +878,6 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
879878
),
880879
});
881880

882-
bind(StorageWrapper).toSelf().inSingletonScope();
883-
bind(CommandContribution).toService(StorageWrapper);
884-
885881
bind(NotificationManager).toSelf().inSingletonScope();
886882
rebind(TheiaNotificationManager).toService(NotificationManager);
887883
bind(NotificationsRenderer).toSelf().inSingletonScope();

‎arduino-ide-extension/src/browser/storage-wrapper.ts

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/browser/storage-wrapper.ts
-37Lines changed: 0 additions & 37 deletions
This file was deleted.

‎arduino-ide-extension/src/test/browser/board-service-provider.test.ts

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/test/browser/board-service-provider.test.ts
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {
1010
StorageService,
1111
} from '@theia/core/lib/browser/storage-service';
1212
import { WindowService } from '@theia/core/lib/browser/window/window-service';
13-
import { CommandContribution } from '@theia/core/lib/common/command';
1413
import {
1514
Disposable,
1615
DisposableCollection,
@@ -22,7 +21,6 @@ import { expect } from 'chai';
2221
import { BoardsDataStore } from '../../browser/boards/boards-data-store';
2322
import { BoardsServiceProvider } from '../../browser/boards/boards-service-provider';
2423
import { NotificationCenter } from '../../browser/notification-center';
25-
import { StorageWrapper } from '../../browser/storage-wrapper';
2624
import {
2725
BoardIdentifierChangeEvent,
2826
BoardsConfig,
@@ -415,7 +413,6 @@ describe('board-service-provider', () => {
415413
bind(LocalStorageService).toSelf().inSingletonScope();
416414
bind(WindowService).toConstantValue(<WindowService>{});
417415
bind(StorageService).toService(LocalStorageService);
418-
bind(CommandContribution).toService(StorageWrapper);
419416
bind(BoardsServiceProvider).toSelf().inSingletonScope();
420417
// IDE2's test console logger does not support `Loggable` arg.
421418
// Rebind logger to suppress `[Function (anonymous)]` messages in tests when the storage service is initialized without `window.localStorage`.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.