Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4398f66

Browse filesBrowse files
author
Akos Kitta
committed
fix: execute the Arduino CLI without a shell
Closes #2112 Ref: #2067 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent b256655 commit 4398f66
Copy full SHA for 4398f66

File tree

1 file changed

+1
-2
lines changed
Filter options

1 file changed

+1
-2
lines changed

‎arduino-ide-extension/src/node/arduino-daemon-impl.ts

Copy file name to clipboardExpand all lines: arduino-ide-extension/src/node/arduino-daemon-impl.ts
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,9 @@ export class ArduinoDaemonImpl
173173
const cliPath = this.getExecPath();
174174
const ready = new Deferred<{ daemon: ChildProcess; port: string }>();
175175
const options = {
176-
shell: true,
177176
env: { ...deepClone(process.env), NO_COLOR: String(true) },
178177
};
179-
const daemon = spawn(`"${cliPath}"`, args, options);
178+
const daemon = spawn(cliPath, args, options);
180179

181180
// If the process exists right after the daemon gRPC server has started (due to an invalid port, unknown address, TCP port in use, etc.)
182181
// we have no idea about the root cause unless we sniff into the first data package and dispatch the logic on that. Note, we get a exit code 1.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.