Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Terminate daemon command when parent process exits; added "--daemonize" flag to keep old behaviour #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Terminate daemon command when parent process exits; added "--daemonize" flag to keep old behaviour #488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e82992
(cosmetic) reorganized runDaemonCommand in a more straighforward way
cmaglie Nov 18, 2019
bc9f1ad
daemon: terminate on parent process ending; added --daemonize flag
cmaglie Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(cosmetic) reorganized runDaemonCommand in a more straighforward way
  • Loading branch information
@cmaglie
cmaglie committed Nov 19, 2019
commit 6e8299278000ed187c6795d31a389890dc3435cc
23 changes: 12 additions & 11 deletions 23 cli/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,27 +50,28 @@ func NewCommand() *cobra.Command {
}

func runDaemonCommand(cmd *cobra.Command, args []string) {
lis, err := net.Listen("tcp", port)
if err != nil {
log.Fatalf("failed to listen: %v", err)
}
s := grpc.NewServer()

userAgentValue := fmt.Sprintf("%s/%s daemon (%s; %s; %s) Commit:%s", globals.VersionInfo.Application,
globals.VersionInfo.VersionString, runtime.GOARCH, runtime.GOOS, runtime.Version(), globals.VersionInfo.Commit)
headers := http.Header{"User-Agent": []string{userAgentValue}}

// register the commands service
coreServer := daemon.ArduinoCoreServerImpl{
headers := http.Header{"User-Agent": []string{
fmt.Sprintf("%s/%s daemon (%s; %s; %s) Commit:%s",
globals.VersionInfo.Application,
globals.VersionInfo.VersionString,
runtime.GOARCH, runtime.GOOS,
runtime.Version(), globals.VersionInfo.Commit)}}
srv_commands.RegisterArduinoCoreServer(s, &daemon.ArduinoCoreServerImpl{
DownloaderHeaders: headers,
VersionString: globals.VersionInfo.VersionString,
Config: globals.Config,
}
srv_commands.RegisterArduinoCoreServer(s, &coreServer)
})

// register the monitors service
srv_monitor.RegisterMonitorServer(s, &daemon.MonitorService{})

lis, err := net.Listen("tcp", port)
if err != nil {
log.Fatalf("failed to listen: %v", err)
}
if err := s.Serve(lis); err != nil {
log.Fatalf("failed to serve: %v", err)
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.