Added option to query cloud API

arduino · cmaglie · Jan 13, 2025 · Dec 23, 2024 · Dec 23, 2024 · Dec 23, 2024
commit 8675a40dffd2b4c603c26eb182db47052830f972
diff --git a/commands/service_board_identify.go b/commands/service_board_identify.go
@@ -32,7 +32,7 @@ func (s *arduinoCoreServerImpl) BoardIdentify(ctx context.Context, req *rpc.Boar
 	defer release()

 	props := properties.NewFromHashmap(req.GetProperties())
-	res, err := identify(pme, props, s.settings, true)
+	res, err := identify(pme, props, s.settings, !req.GetUseCloudApiForUnknownBoardDetection())
 	if err != nil {
 		return nil, err
 	}

diff --git a/rpc/cc/arduino/cli/commands/v1/board.pb.go b/rpc/cc/arduino/cli/commands/v1/board.pb.go
diff --git a/rpc/cc/arduino/cli/commands/v1/board.proto b/rpc/cc/arduino/cli/commands/v1/board.proto
@@ -243,6 +243,9 @@ message BoardIdentifyRequest {
  Instance instance = 1;
  // A set of properties to search (can be taken from a Port message).
  map<string, string> properties = 2;
+  // If set to true, when a board cannot be identified using the installed
+  // platforms, the cloud API will be called to detect the board.
+  bool use_cloud_api_for_unknown_board_detection = 3;
 }

 message BoardIdentifyResponse {