Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Expose golang fqbn package for public use #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Expose golang fqbn package for public use #2768

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccef5a1
Made FQBN parsing package public
cmaglie Nov 27, 2024
3e13de9
100% test coverage
cmaglie Nov 27, 2024
dd8c35a
Precompile validation regexp
cmaglie Nov 29, 2024
a3c9f72
Remove logrus dependency from i18n
cmaglie Nov 29, 2024
b87a215
Isolate locale-handling functions from i18n interface
cmaglie Nov 29, 2024
ea29e02
updated doc
cmaglie Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove logrus dependency from i18n
  • Loading branch information
@cmaglie
cmaglie committed Nov 29, 2024
commit a3c9f72668fbb4134da6e6c0b3ac9aaba46e7916
4 changes: 1 addition & 3 deletions 4 internal/i18n/detect_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@ import (
"strings"
"syscall"
"unsafe"

"github.com/sirupsen/logrus"
)

func getLocaleIdentifier() string {
defer func() {
if r := recover(); r != nil {
logrus.WithField("error", r).Errorf("Failed to get windows user locale")
// ignore error and do not panic
}
}()

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.