Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed locales (translations) not being detected with default config #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not print directly to stdout if locale-detection fails (windows)
  • Loading branch information
cmaglie committed Nov 6, 2024
commit a6e327668e8bd069500a9f3f6bb846aa600c86ee
5 changes: 3 additions & 2 deletions 5 internal/i18n/detect_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@
package i18n

import (
"fmt"
"strings"
"syscall"
"unsafe"

"github.com/sirupsen/logrus"
)

func getLocaleIdentifier() string {
defer func() {
if r := recover(); r != nil {
fmt.Println("failed to get windows user locale", r)
logrus.WithField("error", r).Errorf("Failed to get windows user locale")
}
}()

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.