Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improved compile speed by running multi-threaded library discovery. #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
Loading
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
31949e4
Removed unused field/parameter
cmaglie May 30, 2024
f0a1626
Moved Result structure into his own package
cmaglie May 30, 2024
0990aed
Moving sourceFile object in his own file
cmaglie May 31, 2024
dd46217
Moved uniqueSourceFileQueue in his own file
cmaglie May 31, 2024
a6de50a
Moved includeCache in his own file and made it a field of detector
cmaglie May 31, 2024
bc5f659
Fixed comment
cmaglie May 31, 2024
7f0ee88
Renamed variable (typo)
cmaglie Jun 5, 2024
89a16d1
Simplified handling of de-duplication of cache hit messages
cmaglie May 31, 2024
cc84072
Implemented a better include-cache
cmaglie May 31, 2024
c35baeb
Remove the old, no longer used, includeCache
cmaglie May 31, 2024
d077ae9
Simplified error reporting in library detection
cmaglie May 31, 2024
59accf4
Remove useless targetFilePath variable
cmaglie Jun 1, 2024
fe6273d
Slight improvement of removeBuildFromSketchFiles
cmaglie Jun 2, 2024
1ed2385
Rename variables for clarity
cmaglie Jun 2, 2024
623e23e
Removed hardcoded build.warn_data_percentage in build.options file
cmaglie Jun 2, 2024
885395e
Renamed variables for clarity
cmaglie Jun 2, 2024
bc6a931
Renamed variables for clarity
cmaglie Jun 2, 2024
e28be78
Pre-compute sourceFile fields, and save the in the includes.cache
cmaglie Jun 3, 2024
079a3a4
Added ObjFileIsUpToDate method to sourceFile
cmaglie Jun 3, 2024
917a2ae
Implemented parallel task runner
cmaglie Jun 4, 2024
7f22355
Simplify use of properties.SplitQuotedString
cmaglie Jun 4, 2024
47c5915
Use runner.Task in GCC preprocessor
cmaglie Jun 5, 2024
637c98f
Parallelize library discovery phase in compile
cmaglie Jun 5, 2024
e805906
The number of jobs in library detection now follows --jobs flag
cmaglie Jun 11, 2024
3246db0
Reordered properties construction for clarity
cmaglie Jun 13, 2024
2bf113b
Reordered compileFileWithRecipe for clarity
cmaglie Jun 13, 2024
a9cf210
Added integration test
cmaglie Jun 12, 2024
8913485
fix: libraries are recompiled if the list of include paths changes
cmaglie Jun 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove useless targetFilePath variable
  • Loading branch information
cmaglie committed Feb 13, 2025
commit 59accf4c59e4573c54eb3e6eec8f432ffbe50872
5 changes: 2 additions & 3 deletions 5 internal/arduino/builder/internal/detector/detector.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ func (l *SketchLibrariesDetector) findMissingIncludesInCompilationUnit(
) error {
sourceFile := sourceFileQueue.Pop()
sourcePath := sourceFile.SourcePath()
targetFilePath := paths.NullPath()
depPath := sourceFile.DepfilePath()
objPath := sourceFile.ObjectPath()

Expand Down Expand Up @@ -338,7 +337,7 @@ func (l *SketchLibrariesDetector) findMissingIncludesInCompilationUnit(
}
first = false
} else {
preprocResult, preprocErr = preprocessor.GCC(ctx, sourcePath, targetFilePath, includeFolders, buildProperties)
preprocResult, preprocErr = preprocessor.GCC(ctx, sourcePath, paths.NullPath(), includeFolders, buildProperties)
if l.logger.VerbosityLevel() == logger.VerbosityVerbose {
l.logger.WriteStdout(preprocResult.Stdout)
}
Expand Down Expand Up @@ -371,7 +370,7 @@ func (l *SketchLibrariesDetector) findMissingIncludesInCompilationUnit(

// If preprocess result came from cache, run the preprocessor to obtain the actual error to show
if preprocErr == nil || len(preprocResult.Stderr) == 0 {
preprocResult, preprocErr = preprocessor.GCC(ctx, sourcePath, targetFilePath, includeFolders, buildProperties)
preprocResult, preprocErr = preprocessor.GCC(ctx, sourcePath, paths.NullPath(), includeFolders, buildProperties)
if l.logger.VerbosityLevel() == logger.VerbosityVerbose {
l.logger.WriteStdout(preprocResult.Stdout)
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.