Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[skip-changelog] Add remediation path when tool is not available for an OS #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2023
Merged

[skip-changelog] Add remediation path when tool is not available for an OS #2092

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df8a49
Add instructions on how to contact the package manager to error message
MatteoPologruto Feb 13, 2023
11792ed
Add TestCoreBrokenDependency to core_test.go
MatteoPologruto Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add instructions on how to contact the package manager to error message
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed Mar 6, 2023
commit 7df8a490fbf63f4461409a8c46af6bc878e94406
2 changes: 1 addition & 1 deletion 2 arduino/cores/packagemanager/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (pme *Explorer) DownloadToolRelease(tool *cores.ToolRelease, config *downlo
if resource == nil {
return &arduino.FailedDownloadError{
Message: tr("Error downloading tool %s", tool),
Cause: errors.New(tr("no versions available for the current OS"))}
Cause: errors.New(tr("no versions available for the current OS, try contacting %s", tool.Tool.Package.Email))}
}
return resource.Download(pme.DownloadDir, config, tool.String(), progressCB, "")
}
Expand Down
3 changes: 2 additions & 1 deletion 3 arduino/cores/packagemanager/install_uninstall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,8 @@ func (pme *Explorer) InstallTool(toolRelease *cores.ToolRelease, taskCB rpc.Task

toolResource := toolRelease.GetCompatibleFlavour()
if toolResource == nil {
return fmt.Errorf(tr("no compatible version of %s tools found for the current os"), toolRelease.Tool.Name)
return fmt.Errorf(tr("no compatible version of %s tools found for the current os, try contacting %s"),
toolRelease.Tool.Name, toolRelease.Tool.Package.Email)
Comment on lines +316 to +317
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string can not be correctly translated, you must replace unindexed %s with %[1]s and %[2]s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified here: #2099

}
destDir := pme.PackagesDir.Join(
toolRelease.Tool.Package.Name,
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.