Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix integration test intermittent failure due to download/file in use #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Fix integration test intermittent failure due to download/file in use #1905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec6b414
Do not run go integration tests in parallel
cmaglie Oct 4, 2022
f585f06
Fixed integration test
cmaglie Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not run go integration tests in parallel 
This is required since the integration tests shares the download folder.
Still not ideal, it would be better if the cli could handle concurrent
access to the download folder (from multiple cli processes...), but at
least allows to run the tests without random failures.
  • Loading branch information
@cmaglie
cmaglie committed Oct 4, 2022
commit ec6b414b5f286a4c0d3d1d695b7e864c20cf274f
2 changes: 2 additions & 0 deletions 2 Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,12 @@ tasks:
- task: go:build
dir: '{{default "./" .GO_MODULE_PATH}}'
cmds:
# "-p 1" will not run test in parallel, this is required for integration tests
- |
go test \
-v \
-short \
-p 1 \
-run '{{default ".*" .GO_TEST_REGEX}}' \
{{default "-timeout 10m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} \
-coverprofile=coverage_unit.txt \
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.