Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Optimized 1200-bps touch and upload port detection. Fixed some rare upload-fail corner cases. #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2021
Merged

Optimized 1200-bps touch and upload port detection. Fixed some rare upload-fail corner cases. #1267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a262ded
Experimental: optimized touch + wait
cmaglie Apr 16, 2021
5ee5a80
Refactored upload output and debug info and removed unused functions
cmaglie Apr 19, 2021
6ca680d
Skip serial port touch if the port is not connected
cmaglie Apr 19, 2021
239a85a
Perform touch only if required
cmaglie Apr 22, 2021
26de324
Slightly change test to set serial port properties
cmaglie Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip serial port touch if the port is not connected
  • Loading branch information
@cmaglie
cmaglie committed Apr 19, 2021
commit 6ca680d235a377f1d82cde8ea5acc506e3b7ba7c
2 changes: 1 addition & 1 deletion 2 arduino/serialutils/serialutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func Reset(portToTouch string, wait bool, cb *ResetProgressCallbacks) (string, e
return "", err
}

if portToTouch != "" {
if portToTouch != "" && last[portToTouch] {
if cb != nil && cb.Debug != nil {
cb.Debug(fmt.Sprintf("TOUCH: %v", portToTouch))
}
Expand Down
9 changes: 0 additions & 9 deletions 9 commands/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,15 +335,6 @@ func runProgramAction(pm *packagemanager.PackageManager,
actualPort = newPort
}
}
// ports, err := serial.GetPortsList()
// for _, p := range ports {
// if p == port {
// logrus.Infof("Touching port %s at 1200bps", port)
// if err := serialutils.TouchSerialPortAt1200bps(p); err != nil {
// }
// break
// }
// }
}

if port != "" {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.