Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 3b14b47

Browse filesBrowse files
per1234per1234
authored
[skip changelog] Only download required artifact in Windows Installer job of release workflows (#2743)
The project's nightly build and production release workflows generate a Windows Installer package of Arduino CLI. This is generated from the Windows x86-64 build, which is produced by a prior job. The builds are transferred between jobs by GitHub Actions workflow artifacts, one for each host architecture. Previously, the "create-windows-installer" job that generates the Windows Installer package unnecessarily downloaded all the build artifacts, even though it only requires the Windows x86-64 artifact. In addition to being inefficient, this was problematic because the "create-windows-installer" job is running in parallel with the "notarize-macos" job, which modifies the macOS artifacts. In order to fix a bug in the workflow, the "notarize-macos" job was recently changed to delete the non-notarized macOS artifacts after downloading them so that the job could replace those artifacts with the notarized builds. This caused the "create-windows-installer" job's download of the macOS artifacts to fail when it attempted to download them after the time the parallel "notarize-macos" job had deleted them (but before the "notarize-macos" job had uploaded the artifacts again). The solution to the problem is to configure the "create-windows-installer" job to only download the artifact it requires. This artifact is not modified by any parallel job so there is no danger of a conflict.
1 parent 7ee4cf7 commit 3b14b47
Copy full SHA for 3b14b47

File tree

2 files changed

+2
-4
lines changed
Filter options

2 files changed

+2
-4
lines changed

‎.github/workflows/publish-go-nightly-task.yml

Copy file name to clipboardExpand all lines: .github/workflows/publish-go-nightly-task.yml
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,7 @@ jobs:
201201
- name: Download artifacts
202202
uses: actions/download-artifact@v4
203203
with:
204-
pattern: ${{ env.ARTIFACT_NAME }}-*
205-
merge-multiple: true
204+
name: ${{ env.ARTIFACT_NAME }}-Windows_64bit
206205
path: ${{ env.DIST_DIR }}
207206

208207
- name: Prepare PATH

‎.github/workflows/release-go-task.yml

Copy file name to clipboardExpand all lines: .github/workflows/release-go-task.yml
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,7 @@ jobs:
201201
- name: Download artifacts
202202
uses: actions/download-artifact@v4
203203
with:
204-
pattern: ${{ env.ARTIFACT_NAME }}-*
205-
merge-multiple: true
204+
name: ${{ env.ARTIFACT_NAME }}-Windows_64bit
206205
path: ${{ env.DIST_DIR }}
207206

208207
- name: Prepare PATH

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.