Fix bootloader not replying to SAM-BA commands if USB Reset happens #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: a) power up the board cold from a separate power supply, b) plug in board to PC with USB cable, run bossac to say to hello to the Arduino; all good so far; c) now unplug and replug the USB cable, while keeping the board powered, d) notice that USB re-enumeration takes place OK, the device is still detected just fine by the PC; e) however, if you now run bossac, it just hangs and gets no reply; This is because the `read_job` flag does not get reset back to `false` when a USB Reset event occurs.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
a) power up the board cold from a separate power supply,
b) plug in board to PC with USB cable, run bossac to say to hello to the Arduino; all good so far;
c) now unplug and replug the USB cable, while keeping the board powered,
d) notice that USB re-enumeration takes place OK, the device is still detected just fine by the PC;
e) however, if you now run bossac, it just hangs and gets no reply;
This is because the
read_jobflag does not get reset back tofalsewhen a USB Reset event occurs.