Storage: align partition scheme to mbed boards #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
reviewed
May 30, 2025
| FILE* fp = fopen("/wlan/cacert.pem", "wb"); | ||
|
|
||
| Serial.println("Flashing certificates"); | ||
| uint32_t chunck_size = 128; |
There was a problem hiding this comment.
I am guessing the chunck in the variable name is a misspelling of "chunk".
| @@ -0,0 +1 @@ | ||
| ../../../SSLClient/examples/CertificateUploader/certificates.h |
There was a problem hiding this comment.
Have you verified this will work as expected on a vanilla Windows machine?
Creation of symlinks is disabled by default on Windows. Extracting an archive containing a symlink is treated as creation of a symlink. So I would expect the presence of a symlink in the platform release archive to cause the installation of the platform to fail with an "A required privilege is not held by the client" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.