Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

WIFI Shield support has some bad uses of strncpy() #6564

Copy link
Copy link
Open
@WestfW

Description

@WestfW
Issue body actions

From code inspection:.. These are incorrect calls to strncpy - using the length of the source string rather than the destination buffer...

 libraries/WiFi/extras/wifiHD/src/ard_spi.c - instances of:
    strncpy(keyIdx, (const char*)&params->param, params->paramLen);

hardware/arduino/avr/firmwares/wifishield/wifiHD/src/SOFTWARE_FRAMEWORK/COMPONENTS/WIFI/HD/wl_api.h - instances of:
        strncpy(net.ssid.ssid, "My AP", strlen("My AP"));

Metadata

Metadata

Assignees

No one assigned

    Labels

    Architecture: AVRApplies only to the AVR microcontrollers (Uno, etc.)Applies only to the AVR microcontrollers (Uno, etc.)Component: CoreRelated to the code for the standard Arduino APIRelated to the code for the standard Arduino APIComponent: FirmwareLimited to the contents of the firmwares folder in the core packagesLimited to the contents of the firmwares folder in the core packagesLibrary: WifiThe Wifi Arduino libraryThe Wifi Arduino libraryType: Bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.