Delete project scope #9921

shimonewman · May 28, 2025

Summary by CodeRabbit

Improvements
- Increased consistency and flexibility in file size limits for file preview and download endpoints, now using environment variables or defined constants instead of hardcoded values.
- Unified and improved HTTP response header handling across file-related API endpoints, including consistent memory usage reporting and an extended default cache duration from 30 to 45 days.
Refactor
- Internal method signatures and variable usage updated for improved maintainability and clarity.
- Adjusted method visibility for better extensibility in worker components.
Bug Fixes
- Reverted coroutine hook settings to exclude TCP hooks for improved stability until specific cache and database adapters are used.

deleteProject scope

…ect-scope # Conflicts: # composer.lock # src/Appwrite/Platform/Workers/Builds.php # src/Appwrite/Platform/Workers/Deletes.php

coderabbitai · May 28, 2025

Walkthrough

The changes revert the coroutine hook enabling to exclude TCP hooks, unify and adjust file size limits and HTTP response header handling in file-serving API endpoints, reintroduce the $pools parameter in scheduled task methods and closures, and change the visibility of a deletion method from private to protected. No new public APIs or features are added.

Changes

File(s)	Change Summary
app/cli.php	Reverts coroutine hook enabling to exclude TCP hooks; adds comment explaining TCP hooks are disabled until specific adapters are used.
app/controllers/api/storage.php	Unifies file size limits using environment variables/constants; moves and standardizes HTTP response header setting; increases cache max-age; adds memory usage headers.
src/Appwrite/Platform/Tasks/ScheduleBase.php	Reintroduces `$pools` parameter in `collectSchedules` method signature and its calls; updates closure to capture `$pools`.
src/Appwrite/Platform/Tasks/ScheduleFunctions.php src/Appwrite/Platform/Tasks/ScheduleMessages.php	Adds `$pools` variable to coroutine closures in `enqueueResources` methods.
src/Appwrite/Platform/Workers/Deletes.php	Changes `deleteProject` method visibility from `private` to `protected`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant StorageController
    participant EnvConfig

    Client->>StorageController: Request file (preview/download/view/push)
    StorageController->>EnvConfig: Get size limit and buffer settings
    EnvConfig-->>StorageController: Return config values
    StorageController->>StorageController: Validate file size and range
    StorageController->>Client: Respond with file data and unified headers

Possibly related PRs

Feat sync 1.6 #9920: Opposite change to app/cli.php coroutine hook enabling, enabling all hooks including TCP hooks.

Suggested reviewers

christyjacob4

Poem

🐇 Through tunnels deep in code I leap,
Hooks and headers now in keep.
Limits set with care anew,
Pools return to join the crew.
Protected now, the delete’s might,
Files served fresh, all headers right.
Hop along, the code’s in flight! 🌿✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b27b72 and c50c0e2.

📒 Files selected for processing (6)

app/cli.php (1 hunks)
app/controllers/api/storage.php (7 hunks)
src/Appwrite/Platform/Tasks/ScheduleBase.php (3 hunks)
src/Appwrite/Platform/Tasks/ScheduleFunctions.php (1 hunks)
src/Appwrite/Platform/Tasks/ScheduleMessages.php (1 hunks)
src/Appwrite/Platform/Workers/Deletes.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (6)

src/Appwrite/Platform/Tasks/ScheduleMessages.php
app/cli.php
src/Appwrite/Platform/Tasks/ScheduleFunctions.php
src/Appwrite/Platform/Workers/Deletes.php
src/Appwrite/Platform/Tasks/ScheduleBase.php
app/controllers/api/storage.php

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ect-scope

github-actions · May 28, 2025

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
binutils	2.42-r0	CVE-2025-0840	HIGH
libexpat	2.6.4-r0	CVE-2024-8176	HIGH
libxml2	2.12.7-r0	CVE-2024-56171	HIGH
libxml2	2.12.7-r0	CVE-2025-24928	HIGH
libxml2	2.12.7-r0	CVE-2025-27113	HIGH
libxml2	2.12.7-r0	CVE-2025-32414	HIGH
libxml2	2.12.7-r0	CVE-2025-32415	HIGH
sqlite-libs	3.45.3-r1	CVE-2025-29087	HIGH
xz	5.6.2-r0	CVE-2025-31115	HIGH
xz-libs	5.6.2-r0	CVE-2025-31115	HIGH
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

github-actions · May 28, 2025

✨ Benchmark results

Requests per second: 900
Requests with 200 status code: 162,041
P99 latency: 0.209984232

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	900	1,118
200	162,041	201,232
P99	0.209984232	0.169272067

…ect-scope

shimonewman added 5 commits May 25, 2025 16:07

Deletes.php

b52bc45

deleteProject scope

Deletes.php

c74b534

deleteProject scope

Deletes.php

9861c91

deleteProject scope

Merge branch '1.7.x' of github.com:appwrite/appwrite into delete-proj…

dab57db

…ect-scope # Conflicts: # composer.lock # src/Appwrite/Platform/Workers/Builds.php # src/Appwrite/Platform/Workers/Deletes.php

$deviceForSites signature fix

d24587f

Merge branch '1.7.x' of github.com:appwrite/appwrite into delete-proj…

6b27b72

…ect-scope

shimonewman added 3 commits May 28, 2025 12:10

sync against 1.7

22e28e9

sync against 1.7

873b30c

sync against 1.7

fce74d0

Merge branch '1.7.x' of github.com:appwrite/appwrite into delete-proj…

c50c0e2

…ect-scope

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Delete project scope #9921

Delete project scope #9921

Uh oh!

shimonewman commented May 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

Delete project scope #9921

Are you sure you want to change the base?

Delete project scope #9921

Uh oh!

Conversation

shimonewman commented May 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

Uh oh!

shimonewman commented May 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading