app/controllers/api/databases.php (2)

279-286: ⚠️ Potential issue

Incorrect conditional – misplaced parentheses break the type check

getAttribute(('type') !== $type) evaluates the boolean result of the comparison and uses it as the attribute key, so the logic is never executed the way you expect.
Same issue for the filter check a few lines below.

-    if ($attribute->getAttribute(('type') !== $type)) {
+    if ($attribute->getAttribute('type') !== $type) {
...
-    if ($attribute->getAttribute('type') === Database::VAR_STRING && $attribute->getAttribute(('filter') !== $filter)) {
+    if (
+        $attribute->getAttribute('type') === Database::VAR_STRING &&
+        $attribute->getAttribute('filter') !== $filter
+    ) {

Leaving it as-is will always pass the if-condition and can lead to invalid attribute updates at runtime.

---

295-304: 🛠️ Refactor suggestion

Parameter shadowing hides semantic meaning

Overwriting $collectionId with a fully-qualified internal path makes the variable name lie about its contents and increases cognitive load. It also risks accidental use of the wrong identifier further down.

-    $collectionId =  'database_' . $database->getInternalId() . '_collection_' . $collection->getInternalId();
+    $collectionPath = 'database_' . $database->getInternalId() . '_collection_' . $collection->getInternalId();
...
-                collection: $collectionId,
+                collection: $collectionPath,

Consider renaming to $collectionPath (or similar) to keep the original $collectionId intact.

src/Appwrite/Utopia/Request.php (1)

224-235: Cache key could be made more collision-resistant & nested-array friendly

The overall idea to centralise the cache-key logic is 👍, but two implementation details are worth another look:

1. ksort() only sorts the top-level keys.
   A request like ?filters[a]=1&filters[b]=2 vs ?filters[b]=2&filters[a]=1 will still yield two different cache identifiers because the nested array order is preserved by serialize().
   A quick recursive sort prevents accidental cache misses:

+/**
+ * Recursively sort array keys to ensure deterministic order.
+ */
+private function sortRecursive(array &$array): void
+{
+    ksort($array);
+    foreach ($array as &$value) {
+        if (\is_array($value)) {
+            $this->sortRecursive($value);
+        }
+    }
+}

and then

-        $params = $this->getParams();
-        ksort($params);
+        $params = $this->getParams();
+        $this->sortRecursive($params);

1. md5() is fast but no longer recommended for new code where uniqueness really matters.
   Switching to hash('sha256', …) is a one-liner and keeps collision probability astronomically low.

-        return md5($this->getURI() . '*' . serialize($params) . '*' . APP_CACHE_BUSTER);
+        return hash('sha256', $this->getURI() . '*' . serialize($params) . '*' . APP_CACHE_BUSTER);

Both tweaks are fully backwards-compatible and only strengthen the consistency guarantees of the new helper.

app/controllers/shared/api.php (1)

827-851: Minor nit – consider re-using the already computed $key

$key is now generated once earlier (line 561). Generating it again here is cheap but redundant; re-using the existing variable eliminates an extra call to getParams() and SHA/MD5 work:

-                $key = $request->cacheIdentifier();
+                // `$key` was computed earlier when checking the cache
+                // and is still in scope.

Not critical, but an easy micro-optimisation.

src/Appwrite/Platform/Workers/Deletes.php (1)

528-540: Named argument supplied out of order – may trip static analysers

The mixed positional/named invocation

$this->deleteByGroup(
    $collection->getId(),
    [...],
    database: $dbForProject
);

is perfectly valid in PHP 8, but some static analysers (Psalm, PHPStan < 1.10) still flag it because only the third parameter is named. To silence false positives and improve readability, either:

1. Name all arguments, or
2. Drop the name altogether.

Example:

$this->deleteByGroup(
    collection: $collection->getId(),
    queries:   [Query::select($this->selects), Query::orderAsc()],
    database:  $dbForProject
);

This is a nit, but it helps tooling and future maintenance.

app/controllers/api/databases.php (2)

885-897: Unused $mode parameter can be removed

$mode is injected and accepted as an argument but never referenced in the action body. Keeping it around clutters the signature.

-    ->inject('mode')
...
-    ->action(function (..., bool $enabled, Response $response, Database $dbForProject, string $mode, Event $queueForEvents) {
+    ->action(function (..., bool $enabled, Response $response, Database $dbForProject, Event $queueForEvents) {

The same injection appears in the updateCollection route below – please purge both occurrences.

---

1207-1220: Duplicate unused $mode argument in update-collection route

$mode is injected but never used here either. Removing it will simplify the handler and avoid future confusion.

app/init/resources.php (1)

512-514: Inconsistent removal of telemetry & missing root path for Local device

deviceForLocal now returns new Local() without the Device\Telemetry wrapper and without an explicit root path.
All other deviceFor* resources still wrap their devices with telemetry, so this change introduces an inconsistency and may break instrumentation expectations later on.
Moreover, Utopia\Storage\Device\Local usually expects a root directory; instantiating it with no argument falls back to the current working dir, which is unlikely to be the intended uploads location.

Suggested follow-up:

-return new Local();
+// Decide whether telemetry should be dropped everywhere or re-add it here.
+// If keeping telemetry _off_, provide an explicit root folder:
+return new Local(APP_STORAGE_UPLOADS);

Please verify the design decision and adjust the remaining deviceFor* resources (or revert this one) for consistent behaviour.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting