updates to codebase for python 3#802
Closed
marksmayo wants to merge 3 commits intoappium:masterappium/python-client:masterfrom
Closed
updates to codebase for python 3#802marksmayo wants to merge 3 commits intoappium:masterappium/python-client:masterfrom
marksmayo wants to merge 3 commits intoappium:masterappium/python-client:masterfrom
Conversation
marksmayo
commented
Dec 4, 2022
- removed unnecessary inheritance from object
- removed unnecessary u prefix for strings
- sorted some imports
- converted strings into f-strings
- simplified a conditional
- removed unnecessary inheritance from object - removed unnecessary u prefix for strings - sorted some imports - converted strings into f-strings - simplified a conditional
|
|
Contributor
|
Could you please make sure the CI is ok? |
KazuCocoa
reviewed
Dec 5, 2022
Author
the last two tests have been running for freaking ages, but looks like it's sorted now |
Member
|
I've kicked all of CI tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.