chore: Add better error handling for session creation responses#727
Merged
mykola-mokhnach merged 10 commits intoappium:masterappium/python-client:masterfrom Jun 17, 2022
mykola-mokhnach:resp_checkmykola-mokhnach/python-client:resp_checkCopy head branch name to clipboard
Merged
chore: Add better error handling for session creation responses#727mykola-mokhnach merged 10 commits intoappium:masterappium/python-client:masterfrom mykola-mokhnach:resp_checkmykola-mokhnach/python-client:resp_checkCopy head branch name to clipboard
mykola-mokhnach merged 10 commits intoappium:masterappium/python-client:masterfrom
mykola-mokhnach:resp_checkmykola-mokhnach/python-client:resp_checkCopy head branch name to clipboard
Conversation
KazuCocoa
reviewed
Jun 15, 2022
KazuCocoa
reviewed
Jun 16, 2022
Member
KazuCocoa
left a comment
There was a problem hiding this comment.
Should value in test code revert?
appium/webdriver/webdriver.py looks good.
Contributor
Author
I have both cases now in tests |
KazuCocoa
approved these changes
Jun 16, 2022
Member
KazuCocoa
left a comment
There was a problem hiding this comment.
okay.
I'd prefer to keep value in test_helper.py (not webdriver_test.py) to keep the current appium 2.0 response as mocks, but no issues are there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.