Rebase python3 branch with master by ki4070ma · Pull Request #522 · appium/python-client

ki4070ma · Apr 26, 2020

This is step2 in below steps.

Step2. Rebase python3 branch with master before it is merged

Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.6.0...v2.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Updates the requirements on [autopep8](https://github.com/hhatto/autopep8) to permit the latest version. - [Release notes](https://github.com/hhatto/autopep8/releases) - [Commits](hhatto/autopep8@v1.4...v1.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Updates the requirements on [tox-travis](https://github.com/tox-dev/tox-travis) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox-travis/releases) - [Changelog](https://github.com/tox-dev/tox-travis/blob/master/HISTORY.rst) - [Commits](tox-dev/tox-travis@0.11...0.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](tox-dev/tox@3.6.0...3.14.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore: Fix find_by_images_tests.py * Add installation opencv4nodejs * Fix typo * Add taking screen record to find_by_image_test * Fix errors on the emulator * Remove unused imports

* Add android view matcher as strategy locator * Add docstring * Add functional test * Remove find_elements_by_android_data_matcher * Fix docstring * tweak docstring

* Run all tests * Fix apk file path * Skip find_element_by_image test cases * Skip context switching test * Skip multi tap test on CI * Change strategy for waiting element * Add functions for same steps * Restore unexpected changes * Fix touch_action_tests * Fix * Fix Fix test_driver_swipe * fix * Create _move_to_[target_view] * [test_driver_swipe] Add wait

* add send_keys_direct * override send_keys * tune * add unittest instead of functional test * tweak syntax

if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file

jsf-clabot · Apr 26, 2020

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ KazuCocoa
✅ ki4070ma
✅ mykola-mokhnach
✅ Nrupesh29
✅ Akulavenkatesh
✅ hanneshauer
❌ dependabot-preview[bot]

appium/webdriver/extensions/search_context/android.py

test/functional/android/search_context/find_by_image_tests.py

test/functional/android/search_context/find_by_view_matcher_tests.py

ki4070ma · Apr 26, 2020

appium/webdriver/appium_service.py

            error_msg = f'Appium has failed to start on {host}:{port} within {timeout_ms}ms timeout'
        if error_msg is not None:
-            if stderr == sp.PIPE:
+            if stderr == sp.PIPE and self._process.stderr is not None:


[Notes] To fix mypy error

appium/webdriver/extensions/search_context/android.py

mykola-mokhnach · Apr 26, 2020

CHANGELOG.rst

+
+Fix
+~~~
+- Handling of dictionary-values in WebElement.get_attribute() (#521)


It makes sense to mention that this is the last version supporting Python 2 (because of its EOL)

mykola-mokhnach · Apr 26, 2020

appium/webdriver/appium_connection.py


    @classmethod
-    def get_remote_connection_headers(cls, parsed_url: str, keep_alive: bool = True) -> Dict[str, Any]:
+    def get_remote_connection_headers(cls, parsed_url: 'ParseResult', keep_alive: bool = True) -> Dict[str, Any]:


I love mypy

It's nice catch by mypy.

appium/webdriver/webelement.py

mykola-mokhnach

some minor comments, but althogether 👍

I'm happy if mypy is happy :)

test/functional/android/touch_action_tests.py

ki4070ma · Apr 26, 2020

appium/webdriver/appium_connection.py


    @classmethod
-    def get_remote_connection_headers(cls, parsed_url: str, keep_alive: bool = True) -> Dict[str, Any]:
+    def get_remote_connection_headers(cls, parsed_url: 'ParseResult', keep_alive: bool = True) -> Dict[str, Any]:


It's nice catch by mypy.

* Drop py2 support (#478) * Drop py2 support * Support 3.7+ * Add explicit type declarations (#482) * Fixed mypy warning: touch_action.py * Fixed mypy warning: multi_action.py * Fixed mypy warning: extensions/android * Fixed mypy warning: extensions/search_context * Updated * Revert some changes to run unit test * Review comments * Updates * Updates * Add mypy check to ci.sh * Add mypy to Pipfile * Updates * Update README * Revert unexpected changes * Updates Dict * Revert unexpected changes * Updates * Review comments * Review comments * tweak * Restore and modify changes * Fix wrong return type * Add comments * Revert unexpected changes * Fix mypy error * updates * Add mypy to pre-commit (#485) * chore: Applied some py3 formats (#486) * Removed unused import * Removed unnecessary codes * Applied f'' format instead ''.format() * Fixes * tweak * chore: Fix mypy errors under test folder (#487) * Fix mypy errors under test folder * Add mypy check for test folder to pre-commit * Add mypy check to ci * chore: Remove unittest dependency (#488) * Removed unnecessary codes from calling super * Removed unittest dependency * Upgrade the dependencies to the latest * Removed unused args * Review comments * Update mock requirement from ~=3.0 to ~=4.0 (#502) Updates the requirements on [mock](https://github.com/testing-cabal/mock) to permit the latest version. - [Release notes](https://github.com/testing-cabal/mock/releases) - [Changelog](https://github.com/testing-cabal/mock/blob/master/CHANGELOG.rst) - [Commits](testing-cabal/mock@3.0.0...4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add 'from' to except (#503) * Update pre-commit requirement from ~=1.21 to ~=2.1 (#506) Updates the requirements on [pre-commit](https://github.com/pre-commit/pre-commit) to permit the latest version. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v1.21.0...v2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * doc: Add script to generate sphinx doc (#508) * Add quickstart template files * Update conf file * Update * Update settings * Change project name * Add script to generate docs * Changed header title * Add new line to usage section * Add py.typed file(PEP561) * Replace \n with new line * tweak * Use sphinx format for tables * Rebase python3 branch with master (#522) * Update pytest-cov requirement from ~=2.6 to ~=2.8 (#489) Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.6.0...v2.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update autopep8 requirement from ~=1.4 to ~=1.5 (#490) Updates the requirements on [autopep8](https://github.com/hhatto/autopep8) to permit the latest version. - [Release notes](https://github.com/hhatto/autopep8/releases) - [Commits](hhatto/autopep8@v1.4...v1.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox-travis requirement from ~=0.11 to ~=0.12 (#491) Updates the requirements on [tox-travis](https://github.com/tox-dev/tox-travis) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox-travis/releases) - [Changelog](https://github.com/tox-dev/tox-travis/blob/master/HISTORY.rst) - [Commits](tox-dev/tox-travis@0.11...0.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox requirement from ~=3.6 to ~=3.14 (#494) Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](tox-dev/tox@3.6.0...3.14.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore: Fix find_by_images_tests.py (#495) * chore: Fix find_by_images_tests.py * Add installation opencv4nodejs * Fix typo * Add taking screen record to find_by_image_test * Fix errors on the emulator * Remove unused imports * feat: Add viewmatcher (#480) * Add android view matcher as strategy locator * Add docstring * Add functional test * Remove find_elements_by_android_data_matcher * Fix docstring * tweak docstring * Bump 0.50 * Update changelog for 0.50 * Fix flaky functional tests (#473) * Run all tests * Fix apk file path * Skip find_element_by_image test cases * Skip context switching test * Skip multi tap test on CI * Change strategy for waiting element * Add functions for same steps * Restore unexpected changes * Fix touch_action_tests * Fix * Fix Fix test_driver_swipe * fix * Create _move_to_[target_view] * [test_driver_swipe] Add wait * feat: Add idempotency key header to create session requests (#514) * feat: Override send_keys without file upload function (#515) * add send_keys_direct * override send_keys * tune * add unittest instead of functional test * tweak syntax * Bump 0.51 * Update changelog for 0.51 * test: Fix test_clear flaky functional test (#519) * test: Add unit test for set_value (setImmediateValue) (#518) * chore: Fix int - str comparison error in ios desired capabilities (#517) if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file * fix: Handling of dictionary-values in WebElement.get_attribute() (#521) * Bump 0.52 * Update changelog for 0.52 * Fix mypy error * tweak * Add wait to test * Skip tap_twice test * review comments * Remove unnecessary import Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com> Co-authored-by: Mykola Mokhnach <mokhnach@gmail.com> Co-authored-by: Nrupesh Patel <nrupesh.patel2912@gmail.com> Co-authored-by: Venkatesh <venkatesh@poshmark.com> Co-authored-by: Hannes Hauer <hanneshauer@beeware.at> * chore: Update readme and gitchangelog section role (#524) (#525) * chore: tweak changelog filter * address stoping Python 2 support * 2 instead of 2.0... * tweak readme * Revert some unexpected changes * review comments * Changed bound for TypeVar * Fix crashing ci * Remove beta Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com> Co-authored-by: Mykola Mokhnach <mokhnach@gmail.com> Co-authored-by: Nrupesh Patel <nrupesh.patel2912@gmail.com> Co-authored-by: Venkatesh <venkatesh@poshmark.com> Co-authored-by: Hannes Hauer <hanneshauer@beeware.at>

dependabot-preview bot and others added 20 commits January 26, 2020 20:41

chore: Fix find_by_images_tests.py (#495)

b95776d

* chore: Fix find_by_images_tests.py * Add installation opencv4nodejs * Fix typo * Add taking screen record to find_by_image_test * Fix errors on the emulator * Remove unused imports

feat: Add viewmatcher (#480)

f2bf259

* Add android view matcher as strategy locator * Add docstring * Add functional test * Remove find_elements_by_android_data_matcher * Fix docstring * tweak docstring

Bump 0.50

864b045

Update changelog for 0.50

f14291b

feat: Add idempotency key header to create session requests (#514)

4641b45

feat: Override send_keys without file upload function (#515)

34427a1

* add send_keys_direct * override send_keys * tune * add unittest instead of functional test * tweak syntax

Bump 0.51

5a545d7

Update changelog for 0.51

2141dbd

test: Fix test_clear flaky functional test (#519)

9bdf1f7

test: Add unit test for set_value (setImmediateValue) (#518)

ba64adf

chore: Fix int - str comparison error in ios desired capabilities (#517)

9e1959c

if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file

fix: Handling of dictionary-values in WebElement.get_attribute() (#521)

a2e21d1

Bump 0.52

c702cef

Update changelog for 0.52

cfd99cf

Merge branch 'master' into rebase-master

569342e

ki4070ma commented Apr 26, 2020

View reviewed changes

appium/webdriver/extensions/search_context/android.py Outdated Show resolved Hide resolved

test/functional/android/search_context/find_by_image_tests.py Show resolved Hide resolved

test/functional/android/search_context/find_by_view_matcher_tests.py Show resolved Hide resolved

Fix mypy error

c8d1af3

ki4070ma commented Apr 26, 2020

View reviewed changes

ki4070ma added 3 commits April 26, 2020 13:36

tweak

91a26e8

Add wait to test

e800ce7

Skip tap_twice test

efd0655

ki4070ma changed the title ~~[WIP] Rebase python3 branch with master~~ Rebase python3 branch with master Apr 26, 2020

ki4070ma marked this pull request as ready for review April 26, 2020 06:51

ki4070ma requested a review from KazuCocoa April 26, 2020 06:52

ki4070ma requested a review from mykola-mokhnach April 26, 2020 06:52

mykola-mokhnach reviewed Apr 26, 2020

View reviewed changes

appium/webdriver/webelement.py Show resolved Hide resolved

mykola-mokhnach approved these changes Apr 26, 2020

View reviewed changes

review comments

c378859

ki4070ma commented Apr 26, 2020

View reviewed changes

Remove unnecessary import

56e8e0c

KazuCocoa approved these changes Apr 26, 2020

View reviewed changes

ki4070ma merged commit 78926d2 into appium:python3 Apr 26, 2020

ki4070ma deleted the rebase-master branch January 31, 2021 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase python3 branch with master#522

Rebase python3 branch with master#522
ki4070ma merged 26 commits intoappium:python3appium/python-client:python3from
ki4070ma:rebase-masterCopy head branch name to clipboard

ki4070ma commented Apr 26, 2020 •

edited

Loading

Uh oh!

jsf-clabot commented Apr 26, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ki4070ma Apr 26, 2020 •

edited

Loading

Uh oh!

Uh oh!

mykola-mokhnach Apr 26, 2020

Uh oh!

mykola-mokhnach Apr 26, 2020

Uh oh!

mykola-mokhnach Apr 26, 2020

Uh oh!

ki4070ma Apr 26, 2020

Uh oh!

Uh oh!

mykola-mokhnach left a comment

Uh oh!

Uh oh!

ki4070ma Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Search code, repositories, users, issues, pull requests...

Conversation

ki4070ma commented Apr 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsf-clabot commented Apr 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ki4070ma Apr 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mykola-mokhnach Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

ki4070ma Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mykola-mokhnach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ki4070ma Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ki4070ma commented Apr 26, 2020 •

edited

Loading

jsf-clabot commented Apr 26, 2020 •

edited

Loading

ki4070ma Apr 26, 2020 •

edited

Loading