From 1ae133b329da7b08a4586989ab9f62891d9e621c Mon Sep 17 00:00:00 2001 From: Atsushi Mori Date: Tue, 27 Aug 2019 08:23:02 +0900 Subject: [PATCH 1/4] Fix isort behavior for mock --- .isort.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.isort.cfg b/.isort.cfg index 4128eba2..c0944b0e 100644 --- a/.isort.cfg +++ b/.isort.cfg @@ -1,4 +1,4 @@ [settings] multi_line_output = 3 -known_third_party = dateutil,httpretty,pytest,selenium,setuptools,urllib3 +known_third_party = dateutil,httpretty,pytest,selenium,setuptools,urllib3,mock known_first_party = test From df041bebddbccde2279a7a44b81ed85d46ccebfc Mon Sep 17 00:00:00 2001 From: Atsushi Mori Date: Wed, 28 Aug 2019 00:39:26 +0900 Subject: [PATCH 2/4] Add guide to add 3rd party modules to isort conf --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 2d39e2f9..6059bcf8 100644 --- a/README.md +++ b/README.md @@ -51,6 +51,7 @@ download and unarchive the source tarball (Appium-Python-Client-X.X.tar.gz). ``` $ python -m isort -rc . ``` + - When you use newly 3rd party modules, add it to [.isort.cfg](.isort.cfg) - You can customise `CHANGELOG.rst` with commit messages following [.gitchangelog.rc](.gitchangelog.rc) - It generates readable changelog - Setup From 00303bf05be8ed5747568fe79a620e9eb51486df Mon Sep 17 00:00:00 2001 From: Atsushi Mori Date: Wed, 28 Aug 2019 00:46:34 +0900 Subject: [PATCH 3/4] Add guide for docstrings --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 6059bcf8..e182b705 100644 --- a/README.md +++ b/README.md @@ -51,7 +51,9 @@ download and unarchive the source tarball (Appium-Python-Client-X.X.tar.gz). ``` $ python -m isort -rc . ``` - - When you use newly 3rd party modules, add it to [.isort.cfg](.isort.cfg) + - When you use newly 3rd party modules, add it to [.isort.cfg](.isort.cfg) to keep import order correct +- Docstring style: Google Style + - Refer [link](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html) - You can customise `CHANGELOG.rst` with commit messages following [.gitchangelog.rc](.gitchangelog.rc) - It generates readable changelog - Setup From 68a503da8b56c6b21309f6966cfe66b4eb60ae13 Mon Sep 17 00:00:00 2001 From: Atsushi Mori Date: Wed, 28 Aug 2019 01:04:59 +0900 Subject: [PATCH 4/4] Delete unnecessary codes --- test/functional/android/activities_tests.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/test/functional/android/activities_tests.py b/test/functional/android/activities_tests.py index 63356fe8..dfe869c4 100644 --- a/test/functional/android/activities_tests.py +++ b/test/functional/android/activities_tests.py @@ -15,20 +15,10 @@ import unittest -from appium import webdriver - -from .helper import desired_capabilities from .helper.test_helper import BaseTestCase class ActivitiesTests(BaseTestCase): - def setUp(self): - desired_caps = desired_capabilities.get_desired_capabilities('ApiDemos-debug.apk') - self.driver = webdriver.Remote('http://localhost:4723/wd/hub', desired_caps) - - def tearDown(self): - self.driver.quit() - def test_current_activity(self): activity = self.driver.current_activity self.assertEqual('.ApiDemos', activity)