Fix isort behavior for mock#432
Merged
ki4070ma merged 4 commits intoappium:masterappium/python-client:masterfrom Sep 10, 2019
ki4070ma:fix-isortCopy head branch name to clipboard
Merged
Fix isort behavior for mock#432ki4070ma merged 4 commits intoappium:masterappium/python-client:masterfrom ki4070ma:fix-isortCopy head branch name to clipboard
ki4070ma merged 4 commits intoappium:masterappium/python-client:masterfrom
ki4070ma:fix-isortCopy head branch name to clipboard
Conversation
Member
|
Could you add a note in the development section in README to add the third party library as 'known_third_party'? It may help future contributors |
KazuCocoa
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reproduced #429 (comment) in my local. (
mockwas handled as 1st party module.)So this commit fixes isort behavior for
mockas 3rd party module.