Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add events property#427

Closed
vrunoa wants to merge 17 commits intoappium:masterappium/python-client:masterfrom
vrunoa:add-events-porpertyvrunoa/python-client:add-events-porpertyCopy head branch name to clipboard
Closed

Add events property#427
vrunoa wants to merge 17 commits intoappium:masterappium/python-client:masterfrom
vrunoa:add-events-porpertyvrunoa/python-client:add-events-porpertyCopy head branch name to clipboard

Conversation

@vrunoa
Copy link

@vrunoa vrunoa commented Aug 19, 2019 •
edited
Loading

Get the session to get events timing information. @KazuCocoa @jlipps let me know what you guys think on this approach.

I'm seeing the branch name now "porperty" 🤦🏻‍♂️

KazuCocoa
KazuCocoa reviewed Aug 19, 2019
View reviewed changes
appium/webdriver/webdriver.py Show resolved Hide resolved
test/unit/webdriver/webdriver_test.py Show resolved Hide resolved
ki4070ma
ki4070ma reviewed Aug 19, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
appium/webdriver/webdriver.py Show resolved Hide resolved
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Aug 19, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Aug 19, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated
return self.execute_script('mobile: batteryInfo')

@property
def session_capabilities(self):
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about having session name?

Copy link
Author

@vrunoa vrunoa Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think it make more sense to call it session.

mykola-mokhnach
mykola-mokhnach reviewed Aug 19, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
KazuCocoa
KazuCocoa reviewed Aug 20, 2019
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python -m autopep8 -a -r --global-config .config-pep8 -i . can fix some lint issues pointed by Travis

@ki4070ma ki4070ma mentioned this pull request Aug 20, 2019
Merged
mykola-mokhnach
mykola-mokhnach reviewed Aug 20, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
@ki4070ma
Copy link
Collaborator

ki4070ma commented Aug 20, 2019 •
edited
Loading

Retriggered functional android tests on azure pipelines

  • [Failure case] test_toggle_location_services

Error log

selenium.common.exceptions.WebDriverException: Message:
An unknown server-side error occurred while processing the command.
Original error: Error executing adbExec.
Original error: 'Command '/Users/vsts/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell pm install /data/local/tmp/appium_cache/bc38a04068b79fe3b459303c28bb4b7103bfb6c9.apk' timed out after 20000ms'.
Try to increase the 20000ms adb execution timeout represented by 'uiautomator2ServerInstallTimeout' capability

#413 will fix above error.

@ki4070ma ki4070ma mentioned this pull request Aug 20, 2019
Closed
@ki4070ma
Copy link
Collaborator

ki4070ma commented Aug 20, 2019 •
edited
Loading

Link to #425

mykola-mokhnach
mykola-mokhnach reviewed Aug 21, 2019
View reviewed changes
appium/webdriver/webdriver.py Outdated Show resolved Hide resolved
@dpgraham
Copy link
Contributor

dpgraham commented Aug 21, 2019

@ki4070ma @KazuCocoa can we merge this and publish it?

@dpgraham
Copy link
Contributor

dpgraham commented Aug 21, 2019

@vrunoa is this still just a WIP?

@vrunoa vrunoa changed the title wip: Add events property Add events property Aug 21, 2019
@vrunoa
Copy link
Author

vrunoa commented Aug 21, 2019

Ready for release 🚀

@KazuCocoa
Copy link
Member

KazuCocoa commented Aug 21, 2019

waiting for CI

@ki4070ma
Copy link
Collaborator

ki4070ma commented Aug 22, 2019

Need to.do #427 (review)

@KazuCocoa
Copy link
Member

KazuCocoa commented Aug 22, 2019

mm, next is 'python -m isort -rc .'

@dpgraham dpgraham mentioned this pull request Aug 22, 2019
Merged
@KazuCocoa KazuCocoa closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ki4070ma ki4070ma ki4070ma left review comments

@KazuCocoa KazuCocoa KazuCocoa left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@jlipps jlipps Awaiting requested review from jlipps

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrunoa @ki4070ma @dpgraham @KazuCocoa @mykola-mokhnach
Morty Proxy This is a proxified and sanitized view of the page, visit original site.