#995 add android viewtag for espresso driver#996
Merged
saikrishna321 merged 3 commits intoappium:masterappium/java-client:masterfrom Aug 11, 2018
saikrishna321:masterCopy head branch name to clipboard
Merged
#995 add android viewtag for espresso driver#996saikrishna321 merged 3 commits intoappium:masterappium/java-client:masterfrom saikrishna321:masterCopy head branch name to clipboard
saikrishna321 merged 3 commits intoappium:masterappium/java-client:masterfrom
saikrishna321:masterCopy head branch name to clipboard
Conversation
SrinivasanTarget
requested changes
Aug 10, 2018
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
AndroidDriver needs to implement FindsByAndroidViewTag
| return super.findElement(context); | ||
| } | ||
|
|
||
| throw formIllegalArgumentException(contextClass, FindsByAccessibilityId.class, |
| /** | ||
| * This locator strategy is available in Espresso Driver mode. | ||
| * @since Appium 1.8.2 beta | ||
| * @param tag is an an view tag string |
| import io.appium.java_client.FindsByAndroidUIAutomator; | ||
| import io.appium.java_client.HasOnScreenKeyboard; | ||
| import io.appium.java_client.LocksDevice; | ||
| import io.appium.java_client.*; |
Contributor
There was a problem hiding this comment.
As far as I remember the linter does like star imports
mykola-mokhnach
approved these changes
Aug 10, 2018
Contributor
mykola-mokhnach
left a comment
There was a problem hiding this comment.
LGTM, except of linter issues
SrinivasanTarget
approved these changes
Aug 11, 2018
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
LGTM. Codacy and travis warnings needs to be fixed though.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Related : appium/appium-espresso-driver#189
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply