Add support for "-image" locator type#990
Merged
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom Aug 6, 2018
Merged
Add support for "-image" locator type#990mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom
Conversation
Contributor
Author
|
@jlipps FYI |
SrinivasanTarget
approved these changes
Aug 3, 2018
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
Wow it worked well. Once appium/appium-uiautomator2-server#181 is published one can start interacting at element level by images. Thanks for it @mykola-mokhnach .
jlipps
reviewed
Aug 19, 2018
Member
jlipps
left a comment
There was a problem hiding this comment.
Looks great. I also think it'd be nice to have helper methods which easily allow finding by image path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Based on appium/appium-base-driver#235
Types of changes