Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix #924#951

Merged
SrinivasanTarget merged 2 commits intoappium:masterappium/java-client:masterfrom
SrinivasanTarget:payloadCopy head branch name to clipboard
Jun 20, 2018
Merged

Fix #924#951
SrinivasanTarget merged 2 commits intoappium:masterappium/java-client:masterfrom
SrinivasanTarget:payloadCopy head branch name to clipboard

Conversation

@SrinivasanTarget
Copy link
Member

@SrinivasanTarget SrinivasanTarget commented Jun 19, 2018

Change list

Fix payload for legacy OSS mode.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Payload for MJSWP will look like below,

{
  "desiredCapabilities": {
    "app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
    "platformVersion": "11.3",
    "automationName": "XCuiTest",
    "browserName": "",
    "platformName": "iOS",
    "deviceName": "iPhone 8",
    "launchTimeout": 500000
  }
}

payload for W3c will look like below,

{
  "desiredCapabilities": {
    "app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
    "platformVersion": "11.3",
    "automationName": "XCuiTest",
    "browserName": "",
    "platformName": "iOS",
    "deviceName": "iPhone 8",
    "launchTimeout": 500000
  },
  "capabilities": {
    "alwaysMatch": {
      "appium:app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
      "appium:automationName": "XCuiTest",
      "browserName": "",
      "appium:deviceName": "iPhone 8",
      "appium:launchTimeout": 500000,
      "platformName": "ios",
      "appium:platformVersion": "11.3"
    },
    "firstMatch": [
      {
        
      }
    ]
  }
}

mykola-mokhnach
mykola-mokhnach reviewed Jun 19, 2018
View reviewed changes
src/main/java/io/appium/java_client/remote/NewAppiumSessionPayload.java Outdated
// And write the first capability for gecko13
json.name(CAPABILITIES);
json.beginObject();
if(!forceMobileJSONWP) {
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

@SrinivasanTarget SrinivasanTarget merged commit 29d3473 into appium:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@TikhomirovSergey TikhomirovSergey Awaiting requested review from TikhomirovSergey

@dpgraham dpgraham Awaiting requested review from dpgraham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SrinivasanTarget @KazuCocoa @mykola-mokhnach
Morty Proxy This is a proxified and sanitized view of the page, visit original site.