Add an optional format argument to getDeviceTime and update the documentation#939
Merged
mykola-mokhnach merged 3 commits intoappium:masterappium/java-client:masterfrom Jun 13, 2018
Merged
Add an optional format argument to getDeviceTime and update the documentation#939mykola-mokhnach merged 3 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach merged 3 commits intoappium:masterappium/java-client:masterfrom
Conversation
added 2 commits
June 12, 2018 10:58
SrinivasanTarget
requested changes
Jun 13, 2018
|
|
||
| @Test public void getDeviceTimeTest() { | ||
| String time = driver.getDeviceTime(); | ||
| assertTrue(time.length() == 28); |
Member
There was a problem hiding this comment.
Import statement can also be removed.
Contributor
Author
There was a problem hiding this comment.
which import?
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
it's still used by isAppInstalledTest and lockTest. Codacy usually highlights such cases automatically.
SrinivasanTarget
approved these changes
Jun 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Now it is possible to explicitly set the format specifiers for the returned datetime. Also, the default response format is changed to ISO-8601
Types of changes