Set retry flag to true by default for OkHttpFactory#928
Merged
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom Jun 6, 2018
mykola-mokhnach:okhttp_retrymykola-mokhnach/java-client:okhttp_retryCopy head branch name to clipboard
Merged
Set retry flag to true by default for OkHttpFactory#928mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom mykola-mokhnach:okhttp_retrymykola-mokhnach/java-client:okhttp_retryCopy head branch name to clipboard
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:okhttp_retrymykola-mokhnach/java-client:okhttp_retryCopy head branch name to clipboard
Conversation
This was referenced Jun 2, 2018
|
It would be helpful to make the other private setters and getters (e.g., setResponseCodec(), setCommandCodec() protected as well) - see issue #920. |
added 2 commits
June 2, 2018 15:39
SrinivasanTarget
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
It looks like setting okhttp client to not retry on connection failure by default causes issues while switching contexts (which was previously not the case with apache http client). This PR tries to enforce the default setting to true, but this still requires more testing in the client side, because the problem is not always reproducible.
Types of changes