Init web socket clients lazily#912
Merged
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom May 25, 2018
mykola-mokhnach:websocket_lazymykola-mokhnach/java-client:websocket_lazyCopy head branch name to clipboard
Merged
Init web socket clients lazily#912mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom mykola-mokhnach:websocket_lazymykola-mokhnach/java-client:websocket_lazyCopy head branch name to clipboard
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:websocket_lazymykola-mokhnach/java-client:websocket_lazyCopy head branch name to clipboard
Conversation
SrinivasanTarget
approved these changes
May 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
It looks like web socket lib throws an exception on init for some reason. So it would be safer to init the stuff lazily in order to avoid the java class loader from throwing this exception each time when the driver is instantiated.
See https://stackoverflow.com/questions/50293463/appium-test-case-throws-exception for the reference.
Types of changes