Use default Selenium HTTP client factory#877
Merged
SrinivasanTarget merged 1 commit intoappium:masterappium/java-client:masterfrom Apr 27, 2018
valfirst:use-default-http-client-factoryvalfirst/java-client:use-default-http-client-factoryCopy head branch name to clipboard
Merged
Use default Selenium HTTP client factory#877SrinivasanTarget merged 1 commit intoappium:masterappium/java-client:masterfrom valfirst:use-default-http-client-factoryvalfirst/java-client:use-default-http-client-factoryCopy head branch name to clipboard
SrinivasanTarget merged 1 commit intoappium:masterappium/java-client:masterfrom
valfirst:use-default-http-client-factoryvalfirst/java-client:use-default-http-client-factoryCopy head branch name to clipboard
Conversation
Usage of default Selenium HTTP client factory brings required level of abstraction, clients rely on the same mechanism as for Selenium WD while choosing HTTP client. The implementation used can be changed by setting the `webdriver.http.factory` system property.
mykola-mokhnach
approved these changes
Apr 27, 2018
SrinivasanTarget
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Use default Selenium HTTP client factory instead of its particular implementation.
Types of changes
Details
Usage of default Selenium HTTP client factory brings required level of abstraction, clients rely on the same mechanism as for Selenium WD while choosing HTTP client. The implementation used can be changed by setting the
webdriver.http.factorysystem property.