Implement custom command codec#817
Closed
mykola-mokhnach wants to merge 8 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:appium_w3c_codecmykola-mokhnach/java-client:appium_w3c_codecCopy head branch name to clipboard
Closed
Implement custom command codec#817mykola-mokhnach wants to merge 8 commits intoappium:masterappium/java-client:masterfrom mykola-mokhnach:appium_w3c_codecmykola-mokhnach/java-client:appium_w3c_codecCopy head branch name to clipboard
mykola-mokhnach wants to merge 8 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:appium_w3c_codecmykola-mokhnach/java-client:appium_w3c_codecCopy head branch name to clipboard
Conversation
TikhomirovSergey
approved these changes
Jan 28, 2018
Contributor
TikhomirovSergey
left a comment
There was a problem hiding this comment.
It looks very good. I need to finish my work on capabilities to check all the scope on 1.8.0
added 2 commits
January 29, 2018 07:59
Contributor
Author
|
I've moved the custom codec to a different package and addressed linker complains. Can you please check it one more time @TikhomirovSergey ? |
4 tasks
TikhomirovSergey
added a commit
that referenced
this pull request
Feb 4, 2018
…w3c_codec Addition to the #817. JsonToMobileElementConverter: fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
This is kind of dirty hack to make W3C protocol working properly with Appium. Currently Selenium has a bunch of hardcoded javascript snippets there, which are not going to work in mobile env. I'm also not sure how this is going to work in web context.
Perhaps, @TikhomirovSergey, you'll have better ideas on how to improve it. Check the recent conversation in java_client Slack group for more details.
Types of changes