Removed 'set' prefix from waitForIdleTimeout setting#754
Merged
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom Oct 23, 2017
Merged
Removed 'set' prefix from waitForIdleTimeout setting#754TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
Conversation
SrinivasanTarget
approved these changes
Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
This sets waitForIdleTimeout via settings.
Types of changes
removed prefix "set" from enum constant setWaitForIdleTimeout.
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
appium-uiautomator2-server and appium-android-bootstrap expects "waitForIdleTimeout"
PR implementing waitForIdleTimeout in appium-uiautomator2-server
appium/appium-uiautomator2-server#80