#718 FIX#722
Merged
TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom Sep 8, 2017
TikhomirovSergey:masterCopy head branch name to clipboard
Merged
#718 FIX#722TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:masterCopy head branch name to clipboard
TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Conversation
| } | ||
|
|
||
| ext.seleniumVersion = '[3.5.3,3.5.3]' | ||
| ext.seleniumVersion = '3.5.3' |
Contributor
There was a problem hiding this comment.
nit: add a comment here about version number format restriction
mykola-mokhnach
approved these changes
Sep 7, 2017
SrinivasanTarget
approved these changes
Sep 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
#718 FIX
Types of changes
Details
There was the dependency conflict inside java_clint. As it was resolved by exclusion of malformed artefacts, I think we could return selenium dependency version to its normal form with force compilation. I think that it is the case when the simple solution is enough.