#696 FIX#699
#696 FIX#699TikhomirovSergey merged 3 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:mykola-mokhnach-ideaCopy head branch name to clipboard
Conversation
build.gradle
Outdated
|
|
||
| dependencies { | ||
| compile('org.seleniumhq.selenium:selenium-java:3.4.0'){ | ||
| compile('org.seleniumhq.selenium:selenium-java:3.5.1'){ |
There was a problem hiding this comment.
it would be nice to know whether it is possible to limit the update of major component version, so it would be possible to avoid similar compilation issues in the future. I'm thinking about the same logic, like in package.json for Node JS modules, where one can say "bla: ^1.0" and this will block the component "bla" from major version update (however, minor version updates are allowed)
There was a problem hiding this comment.
@mykola-mokhnach Ok I will google how the similar problems are resolved.
There was a problem hiding this comment.
Seems like this might be a good match to our purposes: https://stackoverflow.com/questions/39664589/use-semantic-versioning-for-a-dependency-in-gradle
There was a problem hiding this comment.
@TikhomirovSergey @mykola-mokhnach i think it only restricts selenium-java dependency and not its sub modules or transitive dependency.
There was a problem hiding this comment.
@TikhomirovSergey We are good to update to 3.5.2 as 3.5.+. I don't see any issues on yesterday's selenium release.
There was a problem hiding this comment.
I've almost created the same. Although having Selenium version assigned to a single variable looks more elegant to me ;)
There was a problem hiding this comment.
or even shorter:
ext.seleniumVersion = '3.4.+'
dependencies {
compile ("org.seleniumhq.selenium:selenium-java:${seleniumVersion}") {
force = true
exclude module: 'cglib'
exclude group: 'com.google.code.gson'
}
compile ("org.seleniumhq.selenium:selenium-support:${seleniumVersion}") {
force = true
}
compile ("org.seleniumhq.selenium:selenium-api:${seleniumVersion}") {
force = true
}
There was a problem hiding this comment.
@mykola-mokhnach @SrinivasanTarget Hi guys. Thank you for the discussion and advices. Today I am going to update the PR
|
|
@mykola-mokhnach |
|
@mykola-mokhnach @SrinivasanTarget I have updated this PR |
|
Yep, now the PR looks much better. @TikhomirovSergey please merge it |
Change list
Types of changes
Details
I suppose that it is the last change and we should publish 5.0.0. All the pended pull-requests will be merged and published at 5.1.0