Update touch ID enroll method#695
Merged
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom Aug 25, 2017
mykola-mokhnach:update_enrollmykola-mokhnach/java-client:update_enrollCopy head branch name to clipboard
Merged
Update touch ID enroll method#695TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom mykola-mokhnach:update_enrollmykola-mokhnach/java-client:update_enrollCopy head branch name to clipboard
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:update_enrollmykola-mokhnach/java-client:update_enrollCopy head branch name to clipboard
Conversation
| * This method is deprecated. Please use {@link #toggleTouchIDEnrollment(boolean)} instead | ||
| */ | ||
| @Deprecated | ||
| default void toggleTouchIDEnrollment() { |
Member
There was a problem hiding this comment.
@mykola-mokhnach We haven't released a version after this implementation. Can we remove this or Do you still wanted it to be marked deprecated?
Contributor
Author
There was a problem hiding this comment.
marking it as deprecated is safer. We can remove as soon as beta is released (what we, actually, always do)
SrinivasanTarget
approved these changes
Aug 18, 2017
TikhomirovSergey
approved these changes
Aug 24, 2017
Contributor
TikhomirovSergey
left a comment
There was a problem hiding this comment.
@mykola-mokhnach It looks fine. I want to run the test, merge this PR if everything is ok and publish it in 5.0.0 on this (26.08.2017-27.08.2017) weekend.
Contributor
Author
|
@KazuCocoa FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Now it is possible to set the desired state for Touch ID Enrolment feature.
Types of changes
Details
the PR is based on appium/appium-xcuitest-driver#506