Clear existing actions/parameters after perform is invoked#663
Merged
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom Jun 30, 2017
mykola-mokhnach:clear_touchmykola-mokhnach/java-client:clear_touchCopy head branch name to clipboard
Merged
Clear existing actions/parameters after perform is invoked#663TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom mykola-mokhnach:clear_touchmykola-mokhnach/java-client:clear_touchCopy head branch name to clipboard
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:clear_touchmykola-mokhnach/java-client:clear_touchCopy head branch name to clipboard
Conversation
Contributor
|
@mykola-mokhnach Hi! I will review it ASAP. Thank you :) |
SrinivasanTarget
approved these changes
Jun 29, 2017
TikhomirovSergey
approved these changes
Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Clear existing actions/parameters after perform method of the corresponding actions chain is invoked
Types of changes
Details
I find the current behaviour confusing, since it may cause issues like this one: appium/appium#8734
The second possible solution might be to make a chain immutable after perform is called, so it will reject all the further parameter/action adding operations after perform method has been invoked once on a chain instance.