Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

enable nativeWebTap setting for iOS#658

Merged
jlipps merged 4 commits intomasterappium/java-client:masterfrom
jlipps-nwtappium/java-client:jlipps-nwtCopy head branch name to clipboard
Jun 17, 2017
Merged

enable nativeWebTap setting for iOS#658
jlipps merged 4 commits intomasterappium/java-client:masterfrom
jlipps-nwtappium/java-client:jlipps-nwtCopy head branch name to clipboard

Conversation

@jlipps
Copy link
Member

@jlipps jlipps commented Jun 16, 2017

Change list

add a setting for iOS to toggle nativeWebTap

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Server-side change: appium/appium-xcuitest-driver#455

@SrinivasanTarget SrinivasanTarget added this to the 5.0.0 milestone Jun 16, 2017
@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 16, 2017 •
edited
Loading

@jlipps Looks good overall. Can you add some tests please? Also our travis is not happy.

@jlipps
Copy link
Member Author

jlipps commented Jun 16, 2017

@SrinivasanTarget added tests, and ran it locally with success. note that this will probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download. not sure what the appium local service runs in the java client... but anyway it works!

@jlipps
Copy link
Member Author

jlipps commented Jun 16, 2017

found the javadoc error that was failing travis. hopefully it will pass now.

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 16, 2017

probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download

We have excluded running tests in CI, so it wouldn't be a problem now. Also this is in pipeline for us.

not sure what the appium local service runs in the java client

Appium local service runs appium as a service automatically at stated port,etc without being started manually.

SrinivasanTarget
SrinivasanTarget approved these changes Jun 17, 2017
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jlipps jlipps merged commit 37f5ed3 into master Jun 17, 2017
@jlipps jlipps deleted the jlipps-nwt branch June 17, 2017 00:29
@jlipps
Copy link
Member Author

jlipps commented Jun 17, 2017

Great! Now how do we publish a beta so someone can use it? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@TikhomirovSergey TikhomirovSergey Awaiting requested review from TikhomirovSergey

Assignees

No one assigned

Labels

enhancement iOS

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jlipps @SrinivasanTarget
Morty Proxy This is a proxified and sanitized view of the page, visit original site.