Addition to the #579#585
Merged
TikhomirovSergey merged 3 commits intoappium:masterappium/java-client:masterfrom Feb 28, 2017
TikhomirovSergey:masterCopy head branch name to clipboard
Merged
Addition to the #579#585TikhomirovSergey merged 3 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:masterCopy head branch name to clipboard
TikhomirovSergey merged 3 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Conversation
The chaining of the activity parameter setting.
Contributor
Author
|
@email2vimalraj You could review it too. |
| driver.startActivity(activity); | ||
| return true; | ||
| }).test(driver)); | ||
|
|
Member
|
Nice Idea @TikhomirovSergey |
| activity.setIntentFlags("0x4000000"); | ||
| activity.setOptionalIntentArguments("-d \"TestIntent\" -t \"text/plain\""); | ||
| driver.startActivity(activity); | ||
| return true; |
Contributor
There was a problem hiding this comment.
is the whole construction with assertTrue and return true really necessary?
Contributor
Author
There was a problem hiding this comment.
@mykola-mokhnach
Yes. It is for codecy checkings. It requires assertions. Also I have an opinion that assertions inside tests methods is the good style.
Contributor
Author
|
@SrinivasanTarget @mykola-mokhnach I will fix the issue later. |
Contributor
|
@TikhomirovSergey : Good idea. Kindly update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
The chaining of the activity parameter setting.
Types of changes
What types of changes are you proposing/introducing to Java client?