Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

#567 fix#568

Merged
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Feb 13, 2017
Merged

#567 fix#568
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard

Conversation

@TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Feb 10, 2017 •
edited
Loading

Change list

#567 fix

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

  • 'isBrowserMethod' is not implemented by default;
  • element generaration was reverted to the old rule which was used before 5.0.0-BETA1

@TikhomirovSergey TikhomirovSergey self-assigned this Feb 10, 2017
@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Feb 10, 2017
@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Feb 10, 2017

@amedvedjev @derunewige
You are invided to review/try this PR too.
If everything is ok then it will be published immideately at the BETA3.

PS. Appium field decorator was changed a little bit. It is not the breaking change... bit it is starting of the refactoring. It is related to the feature request opened by @amedvedjev. It is supposed to be finished at the BETA4.

@amedvedjev
Copy link

amedvedjev commented Feb 10, 2017

@TikhomirovSergey can you give advice how i can try this pull with mine maven project easily?

@TikhomirovSergey TikhomirovSergey merged commit 3d18252 into appium:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

@TikhomirovSergey TikhomirovSergey

Labels

bug

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TikhomirovSergey @amedvedjev @SrinivasanTarget
Morty Proxy This is a proxified and sanitized view of the page, visit original site.